ElderShell/EverWrath
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(Core/Reputations): Faction rep gained by killing mobs is now prop… (#9737)

Browse source 
* fix(Core/Reputations): Faction rep gained by killing mobs is now properly rounded up.

Do not increase reputation rank if exceeds max rank cap.
Fixes #8718
This commit is contained in:
UltraNix 2022-02-05 11:37:00 +01:00 • committed by GitHub
parent 7b041946e1
commit 0b02ba87fc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 91 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/server/scripts/Spells/spell_generic.cpp
View file

@ -2463,7 +2463,7 @@ class spell_gen_oracle_wolvar_reputation : public SpellScript
// Set rep to baserep + basepoints (expecting spillover for oposite faction -> become hated)
// Not when player already has equal or higher rep with this faction
if (player->GetReputationMgr().GetReputation(factionEntry) <= repChange)
player->GetReputationMgr().SetReputation(factionEntry, repChange);
player->GetReputationMgr().SetReputation(factionEntry, static_cast<float>(repChange));
// EFFECT_INDEX_2 most likely update at war state, we already handle this in SetReputation
}