ElderShell/EverWrath
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(Core/Scripts): Fix build and crash when calling uninitialized scripts (#18718)

Browse source 
fix(Core/Scripts): Fix build and crash when calling uninitialized scripts.
This commit is contained in:
Anton Popovichenko 2024-04-12 12:13:37 +02:00 • committed by GitHub
parent f05200fcca
commit 3a6231cb65
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 17 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/server/game/Scripting/ScriptMgr.h
View file

@ -725,6 +725,11 @@ public:
// With this approach, we wouldn't call all available hooks in case if we override just one hook.
static EnabledHooksVector EnabledHooks;
static void InitEnabledHooksIfNeeded(uint16 totalAvailableHooks)
{
EnabledHooks.resize(totalAvailableHooks);
}
static void AddScript(TScript* const script, std::vector<uint16> enabledHooks = {})
{
ASSERT(script);
@ -733,7 +738,7 @@ public:
return;
if (EnabledHooks.empty())
EnabledHooks.resize(script->GetTotalAvailableHooks());
InitEnabledHooksIfNeeded(script->GetTotalAvailableHooks());
if (script->isAfterLoadScript())
{