ElderShell/EverWrath
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 9

fix(Core/Scripts): use DespawnOrUnsummon respawn parameter (#25457)

Browse source 
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Andrew 2026-04-15 05:58:41 -03:00 • committed by GitHub
parent bbd192aff9
commit 3c141d7a48
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

27
src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheChampion/instance_trial_of_the_champion.cpp
View file

@ -176,11 +176,7 @@ public:
case VEHICLE_ARGENT_WARHORSE:
case VEHICLE_ARGENT_BATTLEWORG:
if (InstanceProgress < INSTANCE_PROGRESS_CHAMPIONS_UNMOUNTED && m_auiEncounter[0] == NOT_STARTED)
{
creature->DespawnOrUnsummon();
creature->SetRespawnTime(3);
VehicleList.push_back(creature->GetGUID());
}
else
creature->DespawnOrUnsummon();
break;
@ -301,6 +297,7 @@ public:
switch (InstanceProgress)
{
case INSTANCE_PROGRESS_INITIAL:
break;
case INSTANCE_PROGRESS_GRAND_CHAMPIONS_REACHED_DEST:
case INSTANCE_PROGRESS_CHAMPION_GROUP_DIED_1:
case INSTANCE_PROGRESS_CHAMPION_GROUP_DIED_2:
@ -309,10 +306,8 @@ public:
{
for (ObjectGuid const& guid : VehicleList)
if (Creature* veh = instance->GetCreature(guid))
{
veh->DespawnOrUnsummon();
veh->SetRespawnTime(3);
}
veh->DespawnOrUnsummon(0ms, 3s);
VehicleList.clear();
for( uint8 i = 0; i < 3; ++i )
{
for( uint8 j = 0; j < 3; ++j )
@ -327,11 +322,9 @@ public:
}
if (Creature* c = instance->GetCreature(NPC_AnnouncerGUID))
{
c->DespawnOrUnsummon();
c->SetHomePosition(748.309f, 619.488f, 411.172f, 4.71239f);
c->SetPosition(748.309f, 619.488f, 411.172f, 4.71239f);
c->SetRespawnTime(3);
c->SetNpcFlag(UNIT_NPC_FLAG_GOSSIP);
c->DespawnOrUnsummon(0ms, 3s);
}
InstanceProgress = INSTANCE_PROGRESS_INITIAL;
}
@ -340,10 +333,7 @@ public:
{
if (Creature* announcer = instance->GetCreature(NPC_AnnouncerGUID))
{
announcer->DespawnOrUnsummon();
announcer->SetHomePosition(735.81f, 661.92f, 412.39f, 4.714f);
announcer->SetPosition(735.81f, 661.92f, 412.39f, 4.714f);
announcer->SetRespawnTime(3);
announcer->RemoveNpcFlag(UNIT_NPC_FLAG_GOSSIP);
for( uint8 i = 0; i < 3; ++i )
@ -376,6 +366,7 @@ public:
break;
}
}
announcer->DespawnOrUnsummon(0ms, 3s);
}
}
break;
@ -398,11 +389,9 @@ public:
NPC_ArgentChampionGUID.Clear();
if (Creature* c = instance->GetCreature(NPC_AnnouncerGUID))
{
c->DespawnOrUnsummon();
c->SetHomePosition(743.14f, 628.77f, 411.2f, 4.71239f);
c->SetPosition(743.14f, 628.77f, 411.2f, 4.71239f);
c->SetRespawnTime(3);
c->SetNpcFlag(UNIT_NPC_FLAG_GOSSIP);
c->DespawnOrUnsummon(0ms, 3s);
}
NPC_MemoryEntry = 0;
InstanceProgress = INSTANCE_PROGRESS_CHAMPIONS_DEAD;
@ -422,11 +411,9 @@ public:
NPC_BlackKnightGUID.Clear();
if (Creature* c = instance->GetCreature(NPC_AnnouncerGUID))
{
c->DespawnOrUnsummon();
c->SetHomePosition(743.14f, 628.77f, 411.2f, 4.71239f);
c->SetPosition(743.14f, 628.77f, 411.2f, 4.71239f);
c->SetRespawnTime(3);
c->SetNpcFlag(UNIT_NPC_FLAG_GOSSIP);
c->DespawnOrUnsummon(0ms, 3s);
}
InstanceProgress = INSTANCE_PROGRESS_ARGENT_CHALLENGE_DIED;
}

3
src/server/scripts/Northrend/VioletHold/instance_violet_hold.cpp
View file

@ -172,8 +172,7 @@ public:
if (Creature* sinclari = GetCreature(DATA_SINCLARI))
{
sinclari->AI()->Talk(SAY_SINCLARI_COMPLETE);
sinclari->DespawnOrUnsummon();
sinclari->SetRespawnTime(3);
sinclari->DespawnOrUnsummon(0ms, 3s);
}
}
else if (state == FAIL || state == NOT_STARTED)