ElderShell/EverWrath
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(Core/ObjectGuid): prevent creating copies when looping objects (#6852)

Browse source
This commit is contained in:
Francesco Borzì 2021-07-10 15:54:16 +02:00 • committed by GitHub
parent 2fcafa5f39
commit 4103fca5a4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
40 changed files with 69 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/server/game/Entities/GameObject/GameObject.cpp
View file

@ -212,7 +212,7 @@ void GameObject::ClearRitualList()
if (!animSpell || m_unique_users.empty())
return;
for (ObjectGuid const guid : m_unique_users)
for (ObjectGuid const& guid : m_unique_users)
{
if (Player* channeler = ObjectAccessor::GetPlayer(*this, guid))
if (Spell* spell = channeler->GetCurrentSpell(CURRENT_CHANNELED_SPELL))

2
src/server/game/Entities/GameObject/GameObject.h
View file

@ -843,7 +843,7 @@ public:
void AddToSkillupList(ObjectGuid playerGuid) { m_SkillupList.push_back(playerGuid); }
[[nodiscard]] bool IsInSkillupList(ObjectGuid playerGuid) const
{
for (ObjectGuid const guid : m_SkillupList)
for (ObjectGuid const& guid : m_SkillupList)
if (guid == playerGuid)
return true;