ElderShell/EverWrath
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(Core/ObjectGuid): prevent creating copies when looping objects (#6852)

Browse source
This commit is contained in:
Francesco Borzì 2021-07-10 15:54:16 +02:00 • committed by GitHub
parent 2fcafa5f39
commit 4103fca5a4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
40 changed files with 69 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/server/scripts/EasternKingdoms/BlackrockMountain/BlackwingLair/instance_blackwing_lair.cpp
View file

@ -169,7 +169,7 @@ public:
case DATA_RAZORGORE_THE_UNTAMED:
if (state == DONE)
{
for (ObjectGuid const guid : EggList)
for (ObjectGuid const& guid : EggList)
if (GameObject* egg = instance->GetGameObject(guid))
egg->SetPhaseMask(2, true);
}

2
src/server/scripts/EasternKingdoms/SunkenTemple/instance_sunken_temple.cpp
View file

@ -96,7 +96,7 @@ public:
}
break;
case DATA_ERANIKUS_FIGHT:
for (ObjectGuid const guid : _dragonkinList)
for (ObjectGuid const& guid : _dragonkinList)
{
if (Creature* creature = instance->GetCreature(guid))
if (instance->IsGridLoaded(creature->GetPositionX(), creature->GetPositionY()))

4
src/server/scripts/EasternKingdoms/zone_undercity.cpp
View file

@ -1086,7 +1086,7 @@ public:
}
}
for (ObjectGuid const guid : allianceGuardsGUID)
for (ObjectGuid const& guid : allianceGuardsGUID)
if (Creature* temp = ObjectAccessor::GetCreature(*me, guid))
temp->DespawnOrUnsummon();
@ -2415,7 +2415,7 @@ public:
SaurfangGUID.Clear();
}
for (ObjectGuid const guid : hordeGuardsGUID)
for (ObjectGuid const& guid : hordeGuardsGUID)
if (Creature* temp = ObjectAccessor::GetCreature(*me, guid))
temp->DespawnOrUnsummon();