ElderShell/EverWrath
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 9

Revert "chore(Debug/Scripting): improve debug errors during the unloading scripts (#19643)" (#19951)

Browse source 
This reverts commit db7183a573.

*wrongly use to catch sigsegv
*null check isn't necessary: https://en.cppreference.com/w/cpp/memory/new/operator_delete
This commit is contained in:
Grimdhex 2024-09-12 13:05:12 +02:00 • committed by GitHub
parent 20b443e011
commit 4254827b2c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/server/game/Scripting/ScriptMgr.cpp
View file

@ -30,24 +30,9 @@ namespace
template<typename T>
inline void SCR_CLEAR()
{
for (auto& [scriptID, script] : ScriptRegistry<T>::ScriptPointerList)
for (auto const& [scriptID, script] : ScriptRegistry<T>::ScriptPointerList)
{
try
{
if(script)
{
delete script;
script = nullptr;
}
}
catch (const std::exception& e)
{
LOG_ERROR("scripts.unloading", "Failed to unload script {} with ID: {}. Error: {}", script->GetName(), scriptID, e.what());
}
catch (...)
{
LOG_ERROR("scripts.unloading", "Failed to unload script {} with ID: {}. Unknown error occurred.", script->GetName(), scriptID);
}
delete script;
}
ScriptRegistry<T>::ScriptPointerList.clear();