ElderShell/EverWrath
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(Core/Packets): Fix a crash in MSG_RANDOM_ROLL. (#14545)

Browse source
This commit is contained in:
lineagedr 2023-01-07 21:27:49 +02:00 • committed by GitHub
parent e322c017ea
commit 777a1be394
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/server/game/Entities/Player/Player.cpp
View file

@ -16047,7 +16047,7 @@ void Player::RemoveRestFlag(RestFlag restFlag)
uint32 Player::DoRandomRoll(uint32 minimum, uint32 maximum)
{
ASSERT(minimum <= maximum || maximum <= 10000);
ASSERT(minimum <= maximum);
uint32 roll = urand(minimum, maximum);

6
src/server/game/Handlers/GroupHandler.cpp
View file

@ -567,6 +567,12 @@ void WorldSession::HandleRandomRollOpcode(WorldPackets::Misc::RandomRollClient&
minimum = packet.Min;
maximum = packet.Max;
/** error handling **/
if (minimum > maximum || maximum > 10000) // < 32768 for urand call
{
return;
}
GetPlayer()->DoRandomRoll(minimum, maximum);
}