ElderShell/EverWrath
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(Core/Spells): Fix iterator invalidation crash in deferred spell mod cleanup (#24974)

Browse source 
Co-authored-by: blinkysc <blinkysc@users.noreply.github.com>
This commit is contained in:
blinkysc 2026-03-02 18:26:52 -06:00 • committed by GitHub
parent 8422ec906f
commit 779764383b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/server/game/Spells/Spell.cpp
View file

@ -3992,7 +3992,9 @@ void Spell::_cast(bool skipCheck)
handle_immediate();
// Clean up deferred 0-charge spell modifier auras
for (Aura* aura : m_appliedMods)
// Copy to vector first — aura->Remove() can modify m_appliedMods
std::vector<Aura*> appliedModsCopy(m_appliedMods.begin(), m_appliedMods.end());
for (Aura* aura : appliedModsCopy)
{
if (!aura->IsRemoved() && aura->IsUsingCharges()
&& !aura->GetCharges())