fix(Core): Memleaks fixes - Part II. (#5760)

This commit is contained in:
UltraNix 2021-05-14 10:15:45 +02:00 committed by GitHub
parent 1b6c2004ce
commit 8dd58ebb5b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
19 changed files with 138 additions and 127 deletions

View file

@ -130,7 +130,7 @@ bool ChaseMovementGenerator<T>::DoUpdate(T* owner, uint32 time_diff)
}
if (!i_path || moveToward != _movingTowards)
i_path = new PathGenerator(owner);
i_path = std::make_unique<PathGenerator>(owner);
float x, y, z;
bool shortenPath;
@ -188,6 +188,7 @@ bool ChaseMovementGenerator<T>::DoUpdate(T* owner, uint32 time_diff)
template<>
void ChaseMovementGenerator<Player>::DoInitialize(Player* owner)
{
i_path = nullptr;
_lastTargetPosition.reset();
owner->AddUnitState(UNIT_STATE_CHASE);
}
@ -195,6 +196,7 @@ void ChaseMovementGenerator<Player>::DoInitialize(Player* owner)
template<>
void ChaseMovementGenerator<Creature>::DoInitialize(Creature* owner)
{
i_path = nullptr;
_lastTargetPosition.reset();
owner->SetWalk(false);
owner->AddUnitState(UNIT_STATE_CHASE);
@ -305,7 +307,7 @@ bool FollowMovementGenerator<T>::DoUpdate(T* owner, uint32 time_diff)
return true;
if (!i_path)
i_path = new PathGenerator(owner);
i_path = std::make_unique<PathGenerator>(owner);
float x, y, z;
// select angle
@ -376,6 +378,7 @@ void FollowMovementGenerator<Creature>::_updateSpeed(Creature* owner)
template<class T>
void FollowMovementGenerator<T>::DoInitialize(T* owner)
{
i_path = nullptr;
_lastTargetPosition.reset();
owner->AddUnitState(UNIT_STATE_FOLLOW);
_updateSpeed(owner);