ElderShell/EverWrath
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(Core/Channel): potential nullptr reference in Channel::SetOwner() (#17906)

Browse source
This commit is contained in:
Tristan 'Natrist' Cormier 2023-11-30 14:25:01 -05:00 • committed by GitHub
parent e1cec2bbcf
commit 8eed7ee531
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

30
src/server/game/Chat/Channels/Channel.cpp
View file

@ -884,23 +884,25 @@ void Channel::SetOwner(ObjectGuid guid, bool exclaim)
pinfo.SetModerator(true);
uint8 oldFlag = pinfo.flags;
pinfo.SetOwner(true);
Player* player = ObjectAccessor::FindPlayer(_ownerGUID);
WorldPacket data;
if (ShouldAnnouncePlayer(player))
{
MakeModeChange(&data, _ownerGUID, oldFlag);
SendToAll(&data);
}
FlagsNotify(pinfo.plrPtr);
if (exclaim && ShouldAnnouncePlayer(player))
Player* player = ObjectAccessor::FindPlayer(_ownerGUID);
if (player)
{
MakeOwnerChanged(&data, _ownerGUID);
SendToAll(&data);
if (ShouldAnnouncePlayer(player))
{
WorldPacket data;
MakeModeChange(&data, _ownerGUID, oldFlag);
SendToAll(&data);
if (exclaim)
{
// MakeOwnerChanged will reset the packet for us
MakeOwnerChanged(&data, _ownerGUID);
SendToAll(&data);
}
}
}
}
}