ElderShell/EverWrath
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 9

fix(Scripts/Hyjal): remove very scary call by reference and posis without initialization (#19046)

Browse source 
remove call by reference
This commit is contained in:
Dan 2024-06-11 03:32:50 +02:00 • committed by GitHub
parent cfcb5d5bd7
commit 9684eb437a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/boss_archimonde.cpp
View file

@ -141,24 +141,17 @@ private:
struct npc_doomfire_spirit : public ScriptedAI
{
npc_doomfire_spirit(Creature* creature) : ScriptedAI(creature)
{
_instance = creature->GetInstanceScript();
}
npc_doomfire_spirit(Creature* creature) : ScriptedAI(creature){ }
void Reset() override
{
Position randomPosition;
scheduler.CancelAll();
ScheduleTimedEvent(0s, [&] {
DoomfireMovement(randomPosition, me->GetPosition());
me->GetMotionMaster()->MovePoint(NEAR_POINT, randomPosition);
me->GetMotionMaster()->MovePoint(NEAR_POINT, DoomfireMovement(me->GetPosition()));
}, 1500ms);
}
void DoomfireMovement(Position& targetPos, Position mePos)
Position DoomfireMovement(Position mePos)
{
float angle = mePos.GetOrientation();
float distance = 100.0f;
@ -166,8 +159,8 @@ struct npc_doomfire_spirit : public ScriptedAI
float x = mePos.GetPositionX() + distance * cos(newAngle);
float y = mePos.GetPositionY() + distance * sin(newAngle);
targetPos = Position(x, y, me->GetPositionZ());
return;
Position targetPos = Position(x, y, me->GetPositionZ());
return targetPos;
}
void UpdateAI(uint32 diff) override
@ -180,8 +173,6 @@ struct npc_doomfire_spirit : public ScriptedAI
if (me->HasUnitState(UNIT_STATE_CASTING))
return;
}
private:
InstanceScript* _instance;
};
struct boss_archimonde : public BossAI