ElderShell/EverWrath
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(Core): apply clang-tidy modernize-redundant-void-arg (#3825)

Browse source
This commit is contained in:
Francesco Borzì 2020-12-06 21:38:52 +01:00 • committed by GitHub
parent cba126fa84
commit a7faf4a16f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
15 changed files with 41 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/server/authserver/Server/AuthSocket.cpp
View file

@ -118,7 +118,7 @@ typedef struct AuthHandler
{
eAuthCmd cmd;
uint32 status;
bool (AuthSocket::*handler)(void);
bool (AuthSocket::*handler)();
} AuthHandler;
// GCC have alternative #pragma pack() syntax and old gcc version not support pack(pop), also any gcc version not support it at some paltform
@ -188,15 +188,15 @@ AuthSocket::AuthSocket(RealmSocket& socket) :
}
// Close patch file descriptor before leaving
AuthSocket::~AuthSocket(void) { }
AuthSocket::~AuthSocket() { }
// Accept the connection
void AuthSocket::OnAccept(void)
void AuthSocket::OnAccept()
{
sLog->outBasic("'%s:%d' Accepting connection", socket().getRemoteAddress().c_str(), socket().getRemotePort());
}
void AuthSocket::OnClose(void)
void AuthSocket::OnClose()
{
#if defined(ENABLE_EXTRAS) && defined(ENABLE_EXTRA_LOGS)
sLog->outDebug(LOG_FILTER_NETWORKIO, "AuthSocket::OnClose");

10
src/server/authserver/Server/AuthSocket.h
View file

@ -31,11 +31,11 @@ public:
const static int s_BYTE_SIZE = 32;
AuthSocket(RealmSocket& socket);
~AuthSocket(void) override;
~AuthSocket() override;
void OnRead(void) override;
void OnAccept(void) override;
void OnClose(void) override;
void OnRead() override;
void OnAccept() override;
void OnClose() override;
static ACE_INET_Addr const& GetAddressForClient(Realm const& realm, ACE_INET_Addr const& clientAddr);
@ -57,7 +57,7 @@ public:
private:
RealmSocket& socket_;
RealmSocket& socket(void) { return socket_; }
RealmSocket& socket() { return socket_; }
BigNumber N, s, g, v;
BigNumber b, B;

6
src/server/authserver/Server/RealmAcceptor.h
View file

@ -16,8 +16,8 @@
class RealmAcceptor : public ACE_Acceptor<RealmSocket, ACE_SOCK_Acceptor>
{
public:
RealmAcceptor(void) { }
virtual ~RealmAcceptor(void)
RealmAcceptor() { }
virtual ~RealmAcceptor()
{
if (reactor())
reactor()->cancel_timer(this, 1);
@ -41,7 +41,7 @@ protected:
return reactor()->register_handler(this, ACE_Event_Handler::ACCEPT_MASK);
}
virtual int handle_accept_error(void)
virtual int handle_accept_error()
{
#if defined(ENFILE) && defined(EMFILE)
if (errno == ENFILE || errno == EMFILE)