ElderShell/EverWrath
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(Core/Debugging): Improve SymInitialize fail message (#15424)

Browse source 
* clarify that this is not the crash error, but an error with the crash report itself
* improve formatting and message boundaries
* warn the reader that this means the call stack symbols may be inaccurate

* Cherry-pick commit (6e37438e5d)

Co-authored-by: ihm-tswow <76849026+ihm-tswow@users.noreply.github.com>
This commit is contained in:
Kitzunu 2023-03-17 07:19:03 +01:00 • committed by GitHub
parent 08e1a822f5
commit b32d3506de
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/common/Debugging/WheatyExceptionReport.cpp
View file

@ -674,8 +674,13 @@ void WheatyExceptionReport::GenerateExceptionReport(
// Initialize DbgHelp
if (!SymInitialize(GetCurrentProcess(), 0, TRUE))
{
Log(_T("\n\rCRITICAL ERROR.\n\r Couldn't initialize the symbol handler for process.\n\rError [%s].\n\r\n\r"),
ErrorMessage(GetLastError()));
Log(_T("\r\n"));
Log(_T("----\r\n"));
Log(_T("SYMBOL HANDLER ERROR (THIS IS NOT THE CRASH ERROR)\r\n\r\n"));
Log(_T("Couldn't initialize symbol handler for process when generating crash report\r\n"));
Log(_T("Error: %s\r\n"), ErrorMessage(GetLastError()));
Log(_T("THE BELOW CALL STACKS MIGHT HAVE MISSING OR INACCURATE FILE/FUNCTION NAMES\r\n\r\n"));
Log(_T("----\r\n"));
}
CONTEXT trashableContext = *pCtx;