ElderShell/EverWrath
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore(core): cleanup code p3 (#16073)

Browse source 
* Update MMapMgr.cpp

* Update UpdateFetcher.cpp

* Update AuctionHouseMgr.cpp

* Update AuctionHouseMgr.h

* Update BattlegroundAV.cpp

* Update ChannelMgr.cpp

* Update ThreatMgr.h

* Update Player.h

* Update PlayerSettings.cpp

* Update ObjectMgr.cpp

* Update Guild.cpp

* Update Guild.h

* Update Map.cpp

* Update World.cpp

* Update boss_nefarian.cpp

* Update boss_prince_malchezaar.cpp

* Update boss_venoxis.cpp

* Update zone_elwynn_forest.cpp

* Update zulfarrak.cpp

* Update boss_novos.cpp
This commit is contained in:
天鹿 2023-04-24 19:13:07 +08:00 • committed by GitHub
parent 5dc6f9cf78
commit df77b5f4f7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
20 changed files with 26 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/server/scripts/EasternKingdoms/BlackrockMountain/BlackwingLair/boss_nefarian.cpp
View file

@ -1243,7 +1243,7 @@ class spell_shadowblink : public SpellScript
return;
}
for (auto itr : spellPos)
for (auto& itr : spellPos)
{
float distTarget = target->GetDistance2d(itr.second.m_positionX, itr.second.m_positionY);
if (distTarget <= 30.f)

2
src/server/scripts/EasternKingdoms/Karazhan/boss_prince_malchezaar.cpp
View file

@ -248,7 +248,7 @@ struct boss_malchezaar : public BossAI
void EnfeebleResetHealth()
{
for (auto targets : _enfeebleTargets)
for (auto& targets : _enfeebleTargets)
{
if (Unit* target = ObjectAccessor::GetUnit(*me, targets.first))
{

2
src/server/scripts/EasternKingdoms/ZulGurub/boss_venoxis.cpp
View file

@ -131,7 +131,7 @@ public:
if (!cobraList.empty())
{
for (auto cobras : cobraList)
for (auto& cobras : cobraList)
{
cobras->SetInCombatWithZone();
}

4
src/server/scripts/EasternKingdoms/zone_elwynn_forest.cpp
View file

@ -101,7 +101,7 @@ struct npc_cameron : public ScriptedAI
Acore::Containers::RandomShuffle(MovePosPositions);
// first we break formation because children will need to move on their own now
for (auto guid : _childrenGUIDs)
for (auto& guid : _childrenGUIDs)
if (Creature* child = ObjectAccessor::GetCreature(*me, guid))
if (child->GetFormation())
child->GetFormation()->RemoveMember(child);
@ -228,7 +228,7 @@ struct npc_cameron : public ScriptedAI
// If Formation was disbanded, remake.
if (!me->GetFormation()->IsFormed())
for (auto guid : _childrenGUIDs)
for (auto& guid : _childrenGUIDs)
if (Creature* child = ObjectAccessor::GetCreature(*me, guid))
child->SearchFormation();

2
src/server/scripts/Kalimdor/ZulFarrak/zulfarrak.cpp
View file

@ -573,7 +573,7 @@ public:
if (_summonAddsTimer <= diff)
{
for (auto itr : shadowpriestSezzizAdds[_summmonAddsCount])
for (auto& itr : shadowpriestSezzizAdds[_summmonAddsCount])
{
if (Creature* add = me->SummonCreature(itr.first, itr.second, TEMPSUMMON_DEAD_DESPAWN, 10 * IN_MILLISECONDS))
{

2
src/server/scripts/Northrend/DraktharonKeep/boss_novos.cpp
View file

@ -132,7 +132,7 @@ public:
me->CastSpell(me, SPELL_ARCANE_FIELD, true);
me->CastSpell(me, SPELL_DESPAWN_CRYSTAL_HANDLER, true);
for (auto itr : npcSummon)
for (auto& itr : npcSummon)
{
uint32 summonEntry;
Position summonPos;