Commit graph

2034 commits

Author SHA1 Message Date
Elmsroth
ab02c36e67
feat(Scripts/Commands): Implement ".reset items" command (#18393)
Syntax : .reset items equiped|bags|bank|keyring|currency|vendor_buyback|all|allbags #playername
Delete items in the player inventory (equiped, bank, bags etc...) depending on the chosen option.
#playername : Optionnal target player name (if player is online only). If not provided the command will execute on the selected target player.


Update src/server/scripts/Commands/cs_reset.cpp

Accepted

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Update data/sql/updates/pending_db_world/rev_1708782048020249700.sql

Accepted

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Update data/sql/updates/pending_db_world/rev_1708782048020249700.sql

Accepted

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Update src/server/game/Miscellaneous/Language.h

Accepted

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
fix uint16 vs uint16_t


fix crash and code cleanup

Fix typo

sql fix

Missing typo

selected instead or selecter

AC code style fix

Re-Fix typos

MISSING typos

missing typos
2024-03-15 10:23:31 -03:00
Dan
a21ba7afc2
fix(Scripts/TheEye): another Al'ar hotfix (#18554)
init
2024-03-15 01:05:50 -03:00
Dan
e0bc7d73dd
fix(Scripts/TheEye): make sure Al'ar doesn't schedule abilities multiple times (#18553)
* init

* fix
2024-03-14 06:12:02 -03:00
Dan
28ea5ca879
fix(Scripts/TheEye): maybe fix Al'ar transition (#18552)
initial
2024-03-13 20:53:17 +01:00
sudlud
307c1ab09d
refactor(Core): remove some unused variables (#18538)
- let's get rid of some compiler warnings
2024-03-13 06:52:43 -03:00
Dan
6a58e611ed
fix(Scripts/TheEye): remove auras from Solarian on invisiblity and sniffed spell (#18544)
* init

* add sniffed spell and remove auras on invisible

* prevent true beam being cast on players
2024-03-13 03:42:07 -03:00
Dan
6b5289f373
fix(Scripts/TheEye): allow Solarian to cast on pets/totems (#18539)
init
2024-03-12 06:46:12 -03:00
Dan
a7026e7e39
fix(Scripts/TheEye): make sure Al'ar doesn't cast anything during rebirt + phoenix spawning (#18540)
* init

* more

* uh
2024-03-12 06:44:55 -03:00
Andrew
3a87b5a85e
fix(Scripts/TempestKeep): Kael pyroblast target only main target (#18531) 2024-03-12 00:14:00 +01:00
Dan
3f700645bd
fix(Scripts/TheEye): boss boundaries and Kael door (#18517) 2024-03-10 09:26:00 -03:00
Benjamin Jackson
a9b3f01579
fix(Scripts/Karazhan): Correct chess piece gossip faction check. (#18513)
Correct chess piece gossip faction check.

Co-authored-by: 天鹿 <18535853+pklloveyou@users.noreply.github.com>
2024-03-09 18:46:19 -03:00
Dan
db7475f4f5
fix(Scripts/TheEye): ensure Ember of Al'ar always spawn in the right spot (#18511)
init
2024-03-09 11:08:23 -03:00
Alethrion
ab2f527248
fix(Scripts/Karazhan): Chess Event Cross Faction (#18478)
Chess_Event_Cross_Faction
2024-03-09 09:31:30 -03:00
Dan
903820077c
fix(Scripts/TheEye): make Solarian not overlap casts and not cast arcane missiles into p2 transition (#18480)
* initial

* add voiceline

* move position of yells

* change voicings
2024-03-08 07:55:42 +01:00
Dan
9e7c443f3c
fix(Scripts/TheEye): Al'ar phoenix spawn positions in p2 (#18504)
* wip

* wip

* finalise
2024-03-06 16:51:51 -03:00
Dan
663566af4b
fix(Scripts/TheEye): make sure Solarian does not cast arcane missiles on target with Wrath of the Astromancer active (#18496)
* initial

* add target reset

* fix targetting

* revert
2024-03-04 18:04:48 -03:00
Dan
429cd226f3
fix(Scripts/TheEye): amend Al'ar divebomb timer in p2 (#18495)
initial
2024-03-04 16:54:29 -03:00
Dan
77e1062c4b
fix(Scripts/TheEye): make sure Telonicus doesn't erroneously cast Conflagration and cast Remote Toy instead (#18481)
how the frick did I miss this
2024-03-04 09:34:52 -03:00
Dan
2f2a4be72f
fix(Scripts/TheEye): make sure Al'ar does not melee during transitions (#18479)
* init

* Update boss_alar.cpp
2024-03-04 09:13:33 -03:00
Alethrion
016d9806dc
fix(Scripts/SerpentshrineCavern) Filter Watery Grave Target (#18463)
Filter_Target
2024-03-01 06:46:23 -03:00
Andrew
6df652a8dd
fix(Core/Creature): Prevent combat movement disabled creatures from r… (#18428)
* fix(Core/Creature): Prevent combat movement disabled creatures from repositioning if target moves within model boundary

* fixbuild

* Apply suggestions from code review
2024-02-27 10:11:39 -03:00
Anton Popovichenko
22f2a8f731
fix(Core/Spell): Fix crash in Rogue T10 4P Bonus (#18413) 2024-02-25 19:55:32 -03:00
Andrew
42cde6286f
fix(Scripts/TheEye): Fix Capernian not casting if at max range (#18402) 2024-02-25 17:46:06 -03:00
Anton Popovichenko
34598bfccf
feat(Core/UpdateTime): Improve diff time measurement. (#18387)
* feat(Core/UpdateTime): Improve diff time measurement.

* Codestyle fixes
2024-02-25 12:08:15 -03:00
Dan
a2f8922411
fix(Scripts/TheEye): remove faulty aurascript and do visual transition in normal script instead (#18395) 2024-02-25 11:49:49 -03:00
Dan
def167d7cc
fix(Scripts/TheEye): Kael'thas - allow phases to progress as well when all creatures die as well as other fixes (#18397) 2024-02-25 11:49:19 -03:00
Andrew
d76ca96795
fix(Scripts/TheEye): Fix Capernian chase distance (#18372)
* fix(Scripts/TheEye): Fix Capernian chase distance

* Update boss_kaelthas.cpp
2024-02-21 12:33:05 +01:00
Dan
7e80d8e6bb
fix(Scripts/TerokkarForest): fix behaviour of skull piles in Skettis (#18371)
* initial

* fix

* include ancient skull pile

* fix

* fix with debug

* finalise
2024-02-21 07:41:06 +01:00
Andrew
ea0f214678
fix(Scripts/TheEye): Thaladred should only chase players (#18365) 2024-02-20 19:33:39 +01:00
Dan
e3c282ec1d
fix(Scripts/SSC): remove double spawn of Seer Olum and implement correctly (#18364)
* initial

* fix double definition

* finalise

* remove npc flag in script

* handle in reset

likely fathomlord is created before olum so flag removing doesnt work

* put in instance script
2024-02-20 08:31:14 +01:00
Dan
5955f287ed
fix(Scripts/SSC): do reset threat list for p3 in the right place (#18354)
init
2024-02-19 11:52:59 +01:00
Andrew
5e7e5ce417
fix(Scripts/TheEye): A'lar stop casting flame buffet when any valid t… (#18313)
fix(Scripts/TheEye): A'lar stop casting flame buffet when any valid target is in range
2024-02-12 16:04:35 +01:00
Dan
a4dc083b42
fix(Scripts/Hyjal): move Hyjal boss waypoints to DB (#18299)
* put anetheron movement in wps

* move all wps to db for bosses
2024-02-12 08:17:39 -03:00
Dan
fb49062a56
fix(Scripts/TheEye): make sure Solarian always get reset to REACT STATE aggressive on reset (#18302)
initial
2024-02-12 08:17:24 -03:00
Dan
bf71d8e7f1
fix(Scripts/TheEye): some Al'ar fixes (#18305) 2024-02-12 08:16:46 -03:00
Nathan Handley
df33a57b78
feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243)
* Class Comparison Logic Encapsulation - Parity

* Add Context to IsClass

* Add Unit IsClass script hook

* Replace additional getClass with IsClass

* Update CanUseItem to replace getClass with IsClass

* Add separate context for pet vs ability

* Change Create to Init since not all referenced contexts are creation

* Align spacing in ClassContext

* Drop context on LFGManager max power

* Update IsClass context that wraps around Missle Barrage

* Rename context for swapping weapons

* Be more specific than CLASS_CONTEXT_TALENT

* Remove duplicate context

* Moved IsClass Hook to Player

* Removed unused parameter in virtual base function

* Added maybe_unused to IsClass virtual in order to compile

To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it

* Remove extra blank line

* Add ABILITY_REACTIVE context

* Add context for PET_CHARM

* Remove explicit nullopt check per review

* Code Readability - Change if to if else in pet

Due to the return pattern, this doesn't change functionality in any way

* Add OnPlayer to disambiguate

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-10 12:25:00 -03:00
Nathan Handley
425a490a7b
feat(Core/Unit): New helper HasActivePowerType and script hook OnPlayerHasActivePowerType (#18293)
* Create HasActivePower for script intercept

* Replace relevant player-related getPowerType() comparators with HasActivePowerType

* Change OnPlayerHasActivePowerType to regular bool instead of optional

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-09 06:27:02 -03:00
Dan
d42e04097c
fix(Scripts/TheEye): Solarian movement (#18268)
* first implementation

* better implementation

* don't move before first spell

* chase in p2 again

* Update boss_astromancer.cpp

* oops
2024-02-08 06:05:38 -03:00
Kalimist
65d6bd0472
fix(Core/Creature): hardcoded gossip in zone_azshara (#18289)
* Changing hardcoded text in #define to enum member

- Changing #define to new enum member for AddGossipItemFor method

* Adding SQL Query File

* Forgot to add ';' in DELETE FROM
2024-02-08 07:41:23 +01:00
Dan
af880d516f
refactor(Scripts/ZulAman): refactor Halazzi (#18267)
* initial

* some fixes

* last booboos

* fixes after test

* finale

* actual final

* blegh
2024-02-07 23:43:38 -03:00
Dan
bc25ade498
fix(Scripts/TheEye): refactor Al'ar (#18264)
* initial

* restore quill event

* with ismoving and debug

* final before timers

* clear all debuffs

* remove justreachedhome bossai

* huh?

* some fixes

* more fixes

* add 2 extra platforms for p1

* fix coords

* finalise

* change melt armor timer so it is not delayed

indefinitely - this is because we have a dive after 30 secs
that delays all timers. So at 30 secs we will have melt armor at
33 seconds, which then gets an extra 15 seconds from the delay all and another dive
after 30 so it gets pushed back even more before being able to be cast
2024-02-07 23:43:19 -03:00
Dan
b8118fa06b
fix(Scripts/TheEye): Re-factor Kael'thas (#18272)
* restructuring base files and instance files

* small fix

* some fixes

* fix

* some fixes

* up until kael phase

* weapon despawn fix

* final for now

* some minor details

* fix weapon despawn

* fix by clearing validator

still has debug statements to check how far we get

* finalise with stop casting

* codestyle

* remove redundant delay
2024-02-07 23:42:20 -03:00
Dan
c513da85c8
fix(Scripts/SSC): some Vashj fixes (#18276)
* initial

* script tainted elemental

* sql

* codestyle
2024-02-06 17:47:37 +01:00
Dan
1ec72ae6dc
fix(Scripts/TheEye): add Kael adds to the cpp script (#18257)
* initial

* add sql file to change to script

* make sure scheduler runs

* fix focus gaze mechanic

* leftover tabs

* remove comment
2024-02-04 11:11:12 -03:00
sudlud
186cb58a0f
fix(Scripts/Dalaran): Update Toy Shop Toy Plane behaviour based on sniffs (#18239)
* fix(Scripts/Dalaran): Update Toy Shop Toy Plane behaviour based on sniffs

* update comments and waypoints for smoother movement

* move initalization to Reset() function
2024-02-03 15:11:36 +01:00
sudlud
a2f21bd46e
fix(Scripts/Midsummer): Add SpellScript for "Fire Festival Fortitude" (#18246)
- implement zone wide buff
- Blizzard originally used gameobject 181431 'Fire Festival Fury Trap'
  for this implementation
2024-02-01 09:17:17 -03:00
Dan
ba01bec5b3
fix(Scripts/SSC): make sure Vashj faces the random people when doing Forked Lightning (#18232)
initial
2024-01-30 06:27:24 -03:00
sudlud
e447351b0f
fix(Core/Creature): Remove automated z spawn correction (#18200)
* fix(Core/Creature): Remove automated z spawn correction

* comment out unused parameter

* remove gridLoad parameter from Creature::LoadCreatureFromDB()
2024-01-21 07:33:00 -03:00
Benjamin Jackson
c9bc5084be
fix(Scripts/Midsummer): Correct behavior for Striking Back quests. (#18171)
* Init.

Make use of spell for summoning Ahune's lieutenants, set up gossip/smart scripts for the cast and lieutenant summon speech, and remove permanent lieutenant spawns.

Partially cherry-picked from 91268f6631

Co-Authored-By: Xfurry <172444+xfurry@users.noreply.github.com>

* Use GUIDs for creature delete, add game_event_creature delete.

* Various adjustments.

Move comment block, add Desolace stones gossip menu options, add a delete before insert.

* Set up conditions.

* Add spell cast comments.

Sourced from Wrath Classic Wowhead.

* Add basic combat SmartAI.

* Remove comment block.

* Add creature name comments.

* Use `id1` in preparatory creature delete.

---------

Co-authored-by: Xfurry <172444+xfurry@users.noreply.github.com>
2024-01-21 00:05:18 +01:00
MellianStudios
a89fa73b72
fix(Scripts/Command): prevent crash on set motd (#18203)
* prevent crash on set motd

* updated version

* another version

* Update cs_server.cpp

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-01-21 00:04:46 +01:00