Commit graph

4219 commits

Author SHA1 Message Date
atrapalis
dea3748629
fix(Core/Quest): Correct XP Display when modified by SPELL_AURA_MOD_XP_QUEST_PCT (#19060)
* fix(Core): Correct Quest XP Display when modified by SPELL_AURA_MOD_XP_QUEST_PCT

The quest XP displayed on the gossip window was not modified for auras that increase quest XP gain (e.g. spell ID 57353). This commit corrects the quest XP display when accepting/returning quests.

* refactor(Entities/Player): Added a `CalculateQuestRewardXP()` function to reduce duplicated code

* cleanup(Entities/Creature): Removed now unused variable `playerLevel`

* Apply suggestions from code review

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-06-19 00:41:39 +02:00
avarishd
2cf95ca6cb
fix(Core/Spells): Don't send SMSG_CAST_FAILED for interrupted spells … (#19082)
fix(Core/Spells): Don't send SMSG_CAST_FAILED for interrupted spells after they were launched or channelling was started (this clears cooldown on client)

https: //github.com/TrinityCore/TrinityCore/commit/63bc405faeb7afcf99de6f7531e4ea59065165f4

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2024-06-17 21:26:18 -03:00
Lyuboslav Kotsev
10892a519d
fix(core/spell): Presence of Mind should not apply cooldown mods on c… (#17890)
fix(core/spell): Presence of Mind should not apply cooldown mods on category spells.

Mage T4 set 4 set bonus puts cooldown reduction on Presence of Mind which should not be passed down to category spells,
because in case of infinity cooldown on Arcane Power it does not get reset when you lose the Presence of Mind aura and Arcane Power stays forever in cooldown
or more specifically for 1 month(infinity cooldown).

Closes https://github.com/azerothcore/azerothcore-wotlk/issues/17800
Patch 3.0.9 https://wowpedia.fandom.com/wiki/Patch_3.0.9

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-06-17 22:05:07 +02:00
Benjamin Jackson
4b5468face
fix(Scripts/SlavePens): Rewrite Ahune. (#19075)
* Add WPP SQL output.

* Uncomment all entries.

With one exception, one that does not exist in DB

* Sort all by template entry.

* Add reference names for templates.

* Distinguish summons from static spawns.

* Separate summons from static spawns in SQL parse.

* Add timestamps and spell casts for creatures.

* Init spawn query.

* Init script stuff.

* Init port work.

Co-Authored-By: Gustavo <sirikfoll@hotmail.com>

* Bad flag porting.

* Update stand states and unit flags properly.

* Adjust SQL.

* Add birth spell.

Properly shows the desired animation, to be verified through sniffs if he actually casts it.

* Update Frozen Core model data.

Collected from TC master branch. Will correct with proper data once sniff data becomes available.

* Elaborate rhyme aura text functions.

Co-Authored-By: sudlud <sudlud@users.noreply.github.com>

* Adjust for structure changes.

* Elaborate delete queries.

---------

Co-authored-by: Gustavo <sirikfoll@hotmail.com>
Co-authored-by: sudlud <sudlud@users.noreply.github.com>
2024-06-17 16:57:23 -03:00
Jelle Meeus
916a8ef618
fix(Scripts/BlackTemple): Akama shade missing says (#19076)
Co-authored-by: Keader <keader.android@gmail.com>
2024-06-17 21:42:45 +02:00
AnchyDev
e0cf15db93
fix(Scripts/Misc) CanExecuteCommand renamed and moved to be executed for all commands. (#19081)
* Fix CanExecuteCommand only being executed on command failure.

* Updated for style guide.

* Removed pointless hook call.

* Modified the name of the hook to better reflect function and moved the call to trigger for non-existent commands.

* Updated to OnTryExecuteCommand because Foe has a special place in my heart.

* Forgot to change these 2 areas.
2024-06-17 21:39:11 +02:00
Andrew
5f966e8e0c
chore(Scripts/Hyjal): Remove unneeded Archimonde spell scripts (#19080)
* chore(Scripts/Hyjal): Remove unneeded spell scripts

* use trigger flags

* Update boss_archimonde.cpp

* Update boss_archimonde.cpp
2024-06-17 21:37:43 +02:00
Jelle Meeus
3211c7d884
fix(Scripts/ObsidianSanctum): add Flame Tsunami knockback (#19078)
* refactor spellscript

refactor spellscript

* add flame tsunami knockback
2024-06-16 19:00:07 -03:00
Andrew
95221c4d50
fix(Scripts/Hyjal): Archimonde should gain charges regardless of deat… (#19069)
* fix(Scripts/Hyjal): Archimonde should gain charges regardless of death cause

* Update instance_hyjal.cpp

* fix boss waves
2024-06-16 18:58:14 +02:00
Andrew
9e122a0cad
fix(Core/AI): Fix bosses being stuck IN_PROGRESS if despawnonevade fl… (#19070)
fix(Core/AI): Fix bosses being stuck IN_PROGRESS if despawnonevade flag is used
2024-06-16 18:57:51 +02:00
Benjamin Jackson
d6d49a9e45
refactor(Core/ObjectMgr): Implement display probabilities. (#19068)
* Init.

Cherry-picked from TC commits 9d210476e5 and c488fb219a

Co-Authored-By: Traesh <9392905+traesh@users.noreply.github.com>
Co-Authored-By: Shauren <shauren.trinity@gmail.com>

* Add brute data.

Needs validation against what existed before, i.e. Classic change prevention.

* Add validation info for brute data.

* Remove incomplete data queries.

* Requested changes.

* Whitespace.

* Requested change.

Table name.

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Requested change.

Table name.

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Resolve the funny merge conflicts.

I wonder why git blame doesn't work on a file with 20k lines in it that's odd huh champ.

* Remove unused parameter.

* Remove uses of unused parameter.

* Use unused parameter.

Hopefully?

* I will cry.

* Sobbing endlessly.

* Remove comment.

* Adjust table structure query.

Remove length parameters and allow null for build value.

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Adjust column datatype and add check constraint.

---------

Co-authored-by: Traesh <9392905+traesh@users.noreply.github.com>
Co-authored-by: Shauren <shauren.trinity@gmail.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-06-16 18:12:16 +02:00
Andrew
4e385304c0
fix(Scripts/BlackTemple): Fix najentus enrage not reseting (#19074) 2024-06-16 10:32:04 +02:00
xaenerys0
03031d3616
fix(Scripts/Spells): Flag of Ownership (#18757)
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-06-16 10:20:25 +02:00
Andrew
e255a3ac3e
fix(Scripts/BlackTemple): Fix Najentus not enraging after 8 min (#19066) 2024-06-15 14:01:06 -03:00
Andrew
78aaa136cc
fix(Scripts/BlackTemple): Fix Free Friend spell (#19065) 2024-06-15 13:43:30 -03:00
Jelle Meeus
f846d79478
fix(Core/Pet): Warlock pet handling (#19054)
* dismiss summoned non-hunter pets by removing them

* store createdbyspellid

* Revert "dismiss summoned non-hunter pets by removing them"

This reverts commit eb539e841d882a6c90f743792c91304b0d365a5c.
2024-06-13 10:31:35 -03:00
Jelle Meeus
77d57efdd1
refactor(Scripts/Ulduar): Spell Scripts use registry macros (#19045)
* algalon phase punch

* algalon collapse

* algalon trigger 3 adds

* algalon cosmic smash damage

* algalon big bang

* algalon remove phase

* algalon supermassive fail

* auriaya sentinel blast

* ic shield of runes

* ic assembly meltdown

* ic rune of summoning

* thorim lightning pillar

* thorim trash impale

* kologarn ulduar stone grip cast target

* kologarn stone grip

* kologarn squeezed lifeless

* kologarn stone shout pair

* mimiron rapid burst

* mimiron laser barrage

* ignis scorch

* ignis grab initial

* ignis slag pot

* ulduar energy sap

* ulduar arachnopod damage

* xt tympanic tantrum

* xt gravity bomb damage

* xt gravity bomb pair

* xt searing light spwan life spark pair

* fl load into catapult

* fl auto repair

* fl systems shutdown

* fl pursue

* fl vehicle throw passenger

* fl tar blaze

* fl vehicle grab pyrite

* fl vehicle circuit overload

* fl orbital supports

* fl thorims hammer

* fl transitus shield beam

* fl shield generator

* fl demolisher ride vehicle

* yogg malady of the mind

* yogg brain_link pair

* yogg shadow beacon

* yogg destabilization matrix

* yogg titanic storm

* yogg lunatic gaze

* yogg protective gaze

* yogg empowered

* yogg insane periodic trigger

* yogg insane

* yogg sanity well

* yogg sanity reduce

* yogg empowering shadows

yogg empowering shadows

* yogg in the mwas of the old god

* yogg target selectors

* yogg grim reprisal

* add sql

* fixup! algalon phase punch

* fixup! algalon remove phase

* fixup! ic assembly meltdown

* vezax mark of the faceless periodic

* vezax mark of the faceless drainhealth

* vezax saronite vapors dummy

* vezax saronite vapors damage

* vezax aura of despair

vezax aura of despair style

vezax aura of despair add validate

* vezax aura of despair add validate hasspell

* Revert "vezax aura of despair add validate hasspell"

This reverts commit fccf163399a12119fc468c2fe41ea0798a55eefc.

* sort sql
2024-06-11 20:42:48 +02:00
Dan
9684eb437a
fix(Scripts/Hyjal): remove very scary call by reference and posis without initialization (#19046)
remove call by reference
2024-06-11 03:32:50 +02:00
Andrew
cfcb5d5bd7
fix(Scripts/NPC): Fix arcanite dragonling attacking non flagged players (#19039) 2024-06-10 23:07:48 +02:00
Andrew
57d856cd9e
fix(Scripts/SSC): Fix Serpentshrine Parasites not being summoned (#19041) 2024-06-10 23:07:03 +02:00
Andrew
289758094c
chore(Scripts/Hyjal): Clean up redundancy (#19035) 2024-06-09 17:32:29 -03:00
Dan
8a988fd10a
fix(Scripts/Hyjal): Air Burst back to random target (#19037)
init
2024-06-09 17:32:16 -03:00
Walter Pagani
82d5a42402
chore(Command/unstuck) use command with offline players (#18913)
Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com>
Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>
2024-06-09 08:45:17 -03:00
Jelle Meeus
415f52d662
refactor(Scripts/Naxxramas): Spell Scripts use registry macros (#19034)
* ktz frost blast

* ktz detonate mana

* thaddius pos_neg_charge

* thaddius polarity shift

* sapph frost explosion

* grobbulus poison

* grobbulus mutating injection

* gothik shadow bolt volley

* gluth decimate

* horsemen mark

* add sql

* trigger ci

* Revert "trigger ci"

This reverts commit d8b18d5c5c37d12da1deab0be50941bfe96641a6.

* add validate horsemen mark

* add validate gluth decimate

* add validate gothik shadow mark

* add validate ktz frost blast

* add validate thaddius pos_neg_charge
2024-06-09 08:39:16 -03:00
Dan
bbb0cb43eb
fix(Scripts/Hyjal): some Archimonde fixes (#19031)
* init

* update spellscript

* fix targetting

* Update boss_archimonde.cpp
2024-06-08 16:50:43 +02:00
amed80
eed20b4647
fix(Scripts/Hyjal): Change the spawn and the movement of Doomfire (#19027)
* Doomfire_spirit_speed

* Update boss_archimonde.cpp

* Rename
2024-06-08 13:07:39 +02:00
Benjamin Jackson
bb69f1c3ec
fix(Scripts/HyjalSummit): Assign Death Knight Soul Charge. (#19020)
Init.

Alphabetize and correct DK soul charge assign.
2024-06-07 12:32:02 +02:00
daobashun
0abc66e57d
fix(DB/Stratholme): add Magistrate Barthilas escape event in Stratholme (#17669)
* 1. Added Magistrate Barthilas escape event
2. Fighting the Magistrate Barthilas at the entrance will close the 2 gates leading to the plaza
3. A fight in the slaughterhouse will close the door to the side of the slaughterhouse and will not open until a fight with baron Rivendare
4. Associate some conversation text to Broad*castTextId
5. Added an action for the player to stand up - turn around - salute when the player approaches Aurius
6. Added combat AI to Aurius to prepare for the event where Aurius helps players kill baron Rivendare

* Error in SQL statements is fixed

* Fixed Magistrate Barthilas not turning into human form when he died. Transfiguration should be used on himself

* Fix a misspelling in a note

* fix error

* Save the status of the escape event to the database

* Remove spaces

* Modify the code formatting

* enum format restore

* Modify the enum

* Delete data/sql/updates/pending_db_world/斯坦索姆 fix.sql

Delete files that were accidentally pushed

* fix "Grand Crusader Dathrohan" Unable to speak when transforming and dying and the worldserver console error

* 1 waypoint  1 plus 1s suspension time.
2 Transmission data plus map number.

* The door to the slaughterhouse is opened when there is a player dying and all players in the party are not in combat

* Remove spaces and add comments

* Change as requested

* Update data/sql/updates/pending_db_world/rev_1699566747105058500.sql

Test if this button can be updated directly

Co-authored-by: KJack <kgithub@kellerg.com>

* Use the full sniffing path

* fix error

* edit

* Moved the escape time to smartscript
Delete the closed door

* Remove spaces

* Fixed where barthilas were not in the slaughterhouse after moving to near the slaughterhouse after the save location was restarted

* Delete unused classes

---------

Co-authored-by: KJack <kgithub@kellerg.com>
2024-06-07 08:11:13 +02:00
Lukas
9c2141aa10
fix(Scripts/HallsofStone): corrected Brann dialogue to match live game (#19019)
* fix(Scripts/Halls of Stone): corrected Brann dialogue to match live game

* fix(Scripts/Halls of Stone): corrected Brann dialogue to match live game
2024-06-06 19:40:24 -03:00
Kitzunu
744067b389
fix(Core/Player): Delete by group (#19015)
* fix(Core/Player): Delete by group

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19014

Co-Authored-By: trickerer <onlysuffering@gmail.com>

* Update Player.cpp

* fix build

---------

Co-authored-by: trickerer <onlysuffering@gmail.com>
2024-06-06 20:58:43 +02:00
Jelle Meeus
a1ddf6d520
fix(Script/Item): Fetch Ball (#18906)
* refactor use enum for spellIds

* add sql

* update sql

* enclose Comment with backticks `

* Closes https://github.com/azerothcore/azerothcore-wotlk/issues/565
2024-06-06 14:28:01 +02:00
Andrew
79ec83d03e
fix(Scripts/Hyjal): Fix Azgalor Doom targetting tanks since its an AoE spell (#19012)
* fix(Scripts/Hyjal): Fix Azgalor Doom targetting tanks since its an AoE spell

* Update boss_azgalor.cpp
2024-06-06 00:12:19 +02:00
Anton Popovichenko
c77f9b0fa3
fix(Core/Networking): Fix crash in Proxy Protocol when removing closed sockets. (#19011) 2024-06-05 06:58:50 -03:00
Benjamin Jackson
4909a31328
fix(Core/Battleground): Adjust Eye of the Storm tick rate. (#19007) 2024-06-04 20:19:43 +02:00
sudlud
3913618f87
fix(Core/PlayerQuest): make timed quests failable (#18940) 2024-06-04 18:30:10 +02:00
Andrew
218dce417e
chore(Scripts/Hyjal): Clean up unsafe calls and code style (#19004)
* chore(Scripts/Hyjal): Clean up unsafe calls and code style

* another one
2024-06-03 20:33:07 -03:00
Andrew
8ee980e4ba
fix(Scripts/Hyjal): Anetheron cast Carrion Swarm on non player targets (#19005) 2024-06-03 20:25:58 -03:00
Dan
8256d3cb55
fix(Scripts/Hyjal): archimonde enrage after 10 minutes (#19003)
init
2024-06-03 14:10:44 -03:00
Jelle Meeus
a6425c3630
fix(Core/PetHandler): when dismissing a charmed unit owned by another unit; stop the charm instead of despawning (#18989)
2cdea49d81
2024-06-03 00:42:06 -03:00
Andrew
70fc43ff8d
fix(Script/Hyjal): Fix encounter states not reseting if bosses are de… (#19000)
* fix(Script/Hyjal): Fix encounter states not reseting if bosses are despawned while in combat

* Update instance_hyjal.cpp
2024-06-03 00:31:31 -03:00
Dan
ba8a152479
fix(Scripts/Hyjal): correctly despawn summoned creatures on Jaina/Thrall death (#18997)
* init

* change logic

despawning of bosses is not really done the normal way, but it's forced with a set amount of guids. So we simply need to register the summons as guids as well

* small fixes

* Delete creature_scripts.sql

* Update boss_azgalor.cpp
2024-06-02 17:07:42 +02:00
sudlud
1663045da6
fix(Core/Mail): calculate unReadMails and m_nextMailDelivereTime usin… (#18996)
* fix(Core/Mail): calculate unReadMails and m_nextMailDelivereTime using mail cache

- these values were grepped directly from DB before
-> this change was introduced with azerothcore/azerothcore-wotlk#3420

- the whole mailing system relies on the mails beeing cached in the core
-> these get stored in DB regularly or on specific events

- so apparently the DB is not always in sync with the current mail cache state of the core
-> so grepping data directly from DB is not a good idea at this point

* Update PlayerUpdates.cpp
2024-06-02 09:29:54 -03:00
sudlud
8e9e134924
fix(Scripts/Hyjal): fix some build warnings for unused parameters (#18986) 2024-06-01 12:25:53 +02:00
Dan
0f5992045c
fix(Scripts/Hyjal): increase ranges on doomfire to make movement less inclined to stick close to the boss (#18976)
initial
2024-05-29 23:57:56 +02:00
Dan
9d672f8b62
fix(Scripts/Hyjal): remove summoned mobs on boss evade and reset waves (#18975)
init
2024-05-29 23:57:34 +02:00
Jelle Meeus
0793a979bb
fix(Unit/ProcessTerrainStatusUpdate): prevent removal swimming auras if swimming (#18902)
* do not remove swimming auras if we are swimming

* refactor to isSwimming()

* Update src/server/game/Entities/Unit/Unit.cpp

Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com>

---------

Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com>
2024-05-29 20:17:25 +02:00
Dan
fe6137b0a0
fix(Scripts/Hyjal): tweak movement of Doomfire (#18970)
initial
2024-05-29 08:04:13 +02:00
Andrew
2c246e49d0
fix(Scripts/Hyjal): Anetheron dont cast sleep on tank (#18969) 2024-05-28 19:39:21 -03:00
Andrew
9b363594e7
fix(Scripts/Hyjal): Fix Doom spawning Doomguards twice on expire (#18968) 2024-05-28 19:39:05 -03:00
Andrew
7692b709ac
fix(Scripts/Hyjal): Azgalor doom shouldnt target tank MKII (#18964) 2024-05-28 14:55:28 -03:00