Commit graph

8 commits

Author SHA1 Message Date
Nathan Handley
df33a57b78
feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243)
* Class Comparison Logic Encapsulation - Parity

* Add Context to IsClass

* Add Unit IsClass script hook

* Replace additional getClass with IsClass

* Update CanUseItem to replace getClass with IsClass

* Add separate context for pet vs ability

* Change Create to Init since not all referenced contexts are creation

* Align spacing in ClassContext

* Drop context on LFGManager max power

* Update IsClass context that wraps around Missle Barrage

* Rename context for swapping weapons

* Be more specific than CLASS_CONTEXT_TALENT

* Remove duplicate context

* Moved IsClass Hook to Player

* Removed unused parameter in virtual base function

* Added maybe_unused to IsClass virtual in order to compile

To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it

* Remove extra blank line

* Add ABILITY_REACTIVE context

* Add context for PET_CHARM

* Remove explicit nullopt check per review

* Code Readability - Change if to if else in pet

Due to the return pattern, this doesn't change functionality in any way

* Add OnPlayer to disambiguate

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-10 12:25:00 -03:00
Kargatum
78bdc89881
feat(Core/Battleground): rework bg queue system (#10817) 2022-03-15 14:36:49 -03:00
Kitzunu
455899dc75
fix(Core/Misc): Change const to be after type name (#10591) 2022-02-14 16:05:45 -03:00
Kargatum
f62664c987
refactor(Core/Misc): headers cleanup (#9259) 2021-11-22 17:24:39 +07:00
IntelligentQuantum
0a2c7a3756
refactor(Scripts/Commands): Convert cs_spectator to new system (#8811) 2021-10-29 20:35:01 -03:00
Kargatum
52aa0e9966
feat(License): add new headers information about license (#7941)
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
2021-09-30 13:40:52 +07:00
Kargatum
8568c4fb33
feat(Core): replace ACE network with Boost.Asio (#6574) 2021-07-16 10:43:56 +02:00
Francesco Borzì
aa3896d52a
fix(Core): Undefined symbols ArenaSpectator::HandleSpectatorSpectateC… (#6580) 2021-06-26 16:41:05 +02:00