ElderShell/EverWrath
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
EverWrath/src/server/game
History
Nathan Handley df33a57b78
feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243) 
* Class Comparison Logic Encapsulation - Parity

* Add Context to IsClass

* Add Unit IsClass script hook

* Replace additional getClass with IsClass

* Update CanUseItem to replace getClass with IsClass

* Add separate context for pet vs ability

* Change Create to Init since not all referenced contexts are creation

* Align spacing in ClassContext

* Drop context on LFGManager max power

* Update IsClass context that wraps around Missle Barrage

* Rename context for swapping weapons

* Be more specific than CLASS_CONTEXT_TALENT

* Remove duplicate context

* Moved IsClass Hook to Player

* Removed unused parameter in virtual base function

* Added maybe_unused to IsClass virtual in order to compile

To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it

* Remove extra blank line

* Add ABILITY_REACTIVE context

* Add context for PET_CHARM

* Remove explicit nullopt check per review

* Code Readability - Change if to if else in pet

Due to the return pattern, this doesn't change functionality in any way

* Add OnPlayer to disambiguate

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-10 12:25:00 -03:00
..
Accounts chore(Core/Account): move AccountMgr::IsGMAccount() to class WorldSession (#17845) 2023-11-28 21:44:48 +01:00
Achievements chore(Core/Misc): rename spellInfo pointers (#17914) 2023-12-02 06:03:15 -03:00
Addons chore(Core/Misc): sort includes (#17776) 2023-11-18 17:51:26 +01:00
AI Fix combat movement (#18026) 2024-01-03 09:56:24 +01:00
ArenaSpectator feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243) 2024-02-10 12:25:00 -03:00
AuctionHouse fix(Core/AuctionHouse): fix crash in BuildListAuctionItems (#17222) 2023-09-08 23:09:35 -03:00
Autobroadcast chore(Core/Misc): sort includes (#17776) 2023-11-18 17:51:26 +01:00
Battlefield Revert Visibility Notifier changes (#17682) 2023-11-12 00:48:49 +01:00
Battlegrounds feat(Core/Scripting): move all script objects to separated files (#17860) 2023-12-02 21:13:20 +01:00
Cache refactor(Core/Object): getLevel() -> GetLevel() (#14122) 2022-12-31 17:39:23 +01:00
Calendar chore(core): Cleanup code p2 (#16041) 2023-05-13 15:00:29 -03:00
Chat feat(Core/ChatHandler): Add SendErrorMessage helper (#17919) 2023-12-02 19:25:32 +01:00
Combat fix(Core/ThreatMgr): Remove temp threat on resetting threat list (#18162) 2024-01-13 05:45:43 -03:00
Conditions chore(Core/Misc): sort includes (#17776) 2023-11-18 17:51:26 +01:00
DataStores feat(Core/Scripting): move all script objects to separated files (#17860) 2023-12-02 21:13:20 +01:00
DungeonFinding feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243) 2024-02-10 12:25:00 -03:00
Entities feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243) 2024-02-10 12:25:00 -03:00
Events refactor(Core): remove unused imports (#17094) 2023-08-28 13:39:43 +02:00
Globals fix(Core/Quests): Create quest money reward config and adjust max level bonus reward function. (#18222) 2024-01-31 23:21:27 +01:00
Grids chore(Core): remove useless includes (#18036) 2023-12-23 12:16:27 -03:00
Groups feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243) 2024-02-10 12:25:00 -03:00
Guilds feat(Core/Guild): Allow to limit the amount of members within a guild (#17697) 2023-11-14 17:40:28 +01:00
Handlers feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243) 2024-02-10 12:25:00 -03:00
Instances fix(Core/Misc): typo (#18221) 2024-01-23 21:38:32 +01:00
Loot feat(Core/Scripting): Implement hook OnAfterCalculateLootGroupAmount() (#17456) 2023-10-08 17:18:44 -03:00
Mails feat(Core/Scripting): move all script objects to separated files (#17860) 2023-12-02 21:13:20 +01:00
Maps refactor(Core/GameObject): Move the GameObject state save handling to… (#18080) 2024-01-01 01:51:33 -03:00
Misc feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243) 2024-02-10 12:25:00 -03:00
Miscellaneous fix(CORE/OPvP): Halaa Mechanics not working properly (#15634) 2024-01-14 14:00:53 -03:00
Modules refactor(Core): remove unused imports (#9969) 2022-01-02 20:22:09 +01:00
Motd feat(Core/Scripting): move all script objects to separated files (#17860) 2023-12-02 21:13:20 +01:00
Movement Fix combat movement (#18026) 2024-01-03 09:56:24 +01:00
OutdoorPvP chore(Core/OutdoorPvP): cleanup ptr's, rename private fields (#17778) 2023-11-18 17:51:02 +01:00
Petitions fix and bringing to a unified style warnings of server loading logs to be more visible at server startup (#10970) 2022-03-12 04:57:26 -03:00
Pools chore(Core/Object): Rename GetGOData() to GetGameObjectData() (#14875) 2023-02-05 08:35:52 -03:00
PrecompiledHeaders feat(License): add new headers information about license (#7941) 2021-09-30 13:40:52 +07:00
Quests fix(Core/Quests): Create quest money reward config and adjust max level bonus reward function. (#18222) 2024-01-31 23:21:27 +01:00
Reputation fix(Core/Reputations): Faction rep gained by killing mobs is now prop… (#9737) 2022-02-05 07:37:00 -03:00
Scripting feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243) 2024-02-10 12:25:00 -03:00
Server feat(Core/Scripting): Implement new hook OnBeforePlayerLogout() (#18163) 2024-01-14 00:10:49 +01:00
Skills chore(Core/Misc): rename spellInfo pointers (#17914) 2023-12-02 06:03:15 -03:00
Spells feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243) 2024-02-10 12:25:00 -03:00
Texts refactor(Core): remove unused imports (#17094) 2023-08-28 13:39:43 +02:00
Tickets chore(Core/Misc): Change all TODO to doxygen comment (#14966) 2023-02-12 10:05:34 -03:00
Time refactor(Core/Logging): switch to fmt style for LOG_ (#10366) 2022-01-27 16:44:41 +01:00
Tools chore(Core): remove useless includes (#18036) 2023-12-23 12:16:27 -03:00
Warden chore(Core/Misc): sort includes (#17776) 2023-11-18 17:51:26 +01:00
Weather refactor(Core): remove unused imports (#17094) 2023-08-28 13:39:43 +02:00
World fix(Core/Quests): Create quest money reward config and adjust max level bonus reward function. (#18222) 2024-01-31 23:21:27 +01:00
CMakeLists.txt feat(Core/Modules): add separated lib for modules (#9281) 2021-12-02 20:28:58 +07:00