* fix(Scripts/Midsummer): Implement Ribbon Pole dance effects
* midsummer.cpp: remove whitespaces at end of lines
* midsummer.cpp: fix unused parameter error
* add spacing after 0.0f
* replace Milliseconds(...) by ...ms and Seconds(...) by ...s
* cleanup comments
* remove manual cleanups / despawns from DoCleanupChecks()
- rely on NPC despawn timers
- manual cleanup / removal actually is a bit excessive
* set INTERVAL_DANCING_FLAMES to 15s
* set despawn time to 1min for big dancing flames according to spell 46827
* set spawnDist to 12 for big dancing flames according so spell 46827
* use library function Acore::Containers::RandomShuffle() to shuffle _danclerList
* sql: do not set SmartAI for NPC 17066
already using ScriptName and can't have both
* combine 3 sql files into 1
* remove INTERVAL_... enum values
* remove unnecessary checks of if(_bunny)
* sql: fix smartscript comment
* rename spell define to correct spell name
* fix(Scripts/Midsummer): Randomize ribbon pole beam color
* Update data/sql/updates/pending_db_world/rev_1695820418952974700.sql
Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com>
* Add Validate() to spell script spell_midsummer_ribbon_pole
---------
Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com>
* refactor(Scripts/Midsummer): Assign enum values to gameobjects and spells
* rename GO_TORCH_TOSS_TARGET_BUNNY to NPC_TORCH_TOSS_TARGET_BUNNY
* add more enum values to enum flingTorch
* fix(Scripts/Midsummer): Make beam target Ribbon Pole top
progress #12145
* refactor(Scripts/Midsummer): shorten spell_midsummer_ribbon_pole_visual::UpdateTarget
- spell 45644 used to be linked to spell_midsummer_juggling_torch
- spell 45644 was later linked to new implementation
spell_midsummer_torch_catch in e1e4c6cddc
- old implementation of spell 45644 was never removed from
spell_midsummer_juggling_torch
* fix (core): macos12 depreciation workflow error
Fix workflow error message:
azerothcore-wotlk/src/common/Utilities/Util.cpp:558:9: fatal error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
sprintf(buffer, "%02X", bytes[i]);
* Update BattlegroundAV.cpp
* more macos12 fixit
* Update spell_generic.cpp
* refactor(Core/UnitAI): Update TargetSelector.
Cherry-pick:
*https://github.com/TrinityCore/TrinityCore/pull/19930
Co-authored-by: Treeston <treeston@users.noreply.github.com>
* fix GGC/CLang errors in scripts
* .
* missing a file and fix a script error
* .
* fix path changes dude to a miss click in the second commit
* .
Co-authored-by: Maelthyrr <lynethris@protonmail.ch>
Co-authored-by: Treeston <treeston@users.noreply.github.com>
